Skip to content

cpu/esp*: compile time configurations for ESP MCUs #10766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2019
Merged

cpu/esp*: compile time configurations for ESP MCUs #10766

merged 2 commits into from
Jan 17, 2019

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR adds the groups for ESP MCUs to the config group and adds first compile-time configuration macros to these groups.

Testing procedure

Generate the documentation with make doc and check Modules / Compile time configurations page for the modules ESP8266 compile configurations and ESP32 compile configurations.

Issues/PRs references

This PR is prerequisite for PR #10762 and further upcoming PRs.

@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: doc Area: Documentation Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jan 14, 2019
@gschorcht gschorcht requested a review from jia200x January 14, 2019 11:25
@jia200x
Copy link
Member

jia200x commented Jan 14, 2019

great! Thank you!

@jia200x jia200x added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 14, 2019
@gschorcht
Copy link
Contributor Author

@jia200x But it is not complete yet, just a beginning.

@smlng smlng mentioned this pull request Jan 16, 2019
Merged
@gschorcht gschorcht mentioned this pull request Jan 16, 2019
Merged
@gschorcht
Copy link
Contributor Author

@jia200x Is it possible to get this very small changes reviewed and mergeds? Thanks.

MrKevinWeiss
MrKevinWeiss approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looked at the code, and ACK!

@gschorcht
Copy link
Contributor Author

@MrKevinWeiss Thank you for reviewing.

@gschorcht gschorcht merged commit c061729 into RIOT-OS:master Jan 17, 2019
@gschorcht gschorcht deleted the esp_compile_time_configs branch January 17, 2019 15:39
@aabadie aabadie added this to the Release 2019.01 milestone Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@jia200x jia200x Awaiting requested review from jia200x

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @jia200x @MrKevinWeiss @aabadie