Skip to content

makefiles/docker: fix docker build on osx #10564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

makefiles/docker: fix docker build on osx #10564

wants to merge 1 commit into from

Conversation

jthacker
Copy link
Contributor

@jthacker jthacker commented Dec 6, 2018

Contribution description

On OSX, when running make BUILD_IN_DOCKER=1, it fails with the following error

docker: Error response from daemon: Mounts denied:
The path /etc/localtime
is not shared from OS X and is not known to Docker.
You can configure shared paths from Docker -> Preferences... -> File Sharing.
See https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.

/etc/localtime is not shared by default. Even after adding it to the shared file list, it still doesn't work because of the symlink. This patch resolves any symlinks which on OSX go to files under /private which are by default shared.

Testing procedure

This was run on OSX and showed that there were no issues.

Issues/PRs references

Fixes #10287

@aabadie aabadie mentioned this pull request Dec 6, 2018
Merged
@jcarrano jcarrano added State: duplicate State: The issue/PR is a duplicate of another issue/PR Area: build system Area: Build system OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Dec 7, 2018
@jcarrano
Copy link
Contributor

jcarrano commented Dec 7, 2018

I'm closing this as a duplicate of #10568. Had I seen this PR first, I would have reviewed it.

@jcarrano jcarrano closed this Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: build system Area: Build system OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system State: duplicate State: The issue/PR is a duplicate of another issue/PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker: docker cannot access /etc/localtime on OS X
2 participants
@jthacker @jcarrano