gnrc_ipv6_nib: provide interface on packet queueing #10356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the first packet to a new link-local address will not be delivered in non-6Lo environments, since the interface is not provided. With this change, if an internet was provided to the address resolver it will be stored within an allocated `gnrc_netif_hdr_t`. At this point [IPv6 already striped](netif strip) the packet of its netif header, so there is no risk that there will be to, in case it was provided and the `netif` came from its existence.
|
I'm reviewing this! |
|
It didn't work but I was using the |
jia200x
approved these changes
Nov 9, 2018
|
Backport provided in #10360 |
Wait, what did you mean by that? |
Nevermind, I compiled in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
During release testing I noticed that reproducibly the first ping is always timing out. Some investigation revealed that this is a bug in the address resolver that involves dropping any interface information it has, when it is queueing a packet for which it doesn't know the link-layer address yet.
Without this the first packet to a new link-local address will not be delivered in non-6Lo environments, since the interface is not provided. With this change, if an internet was provided to the address resolver it
will be stored within an allocated
gnrc_netif_hdr_t.At this point [IPv6 already striped](netif strip) the packet of its netif header, so there is no risk that there will be to, in case it was provided and the
netifcame from its existence.Testing procedure
Compile
gnrc_networkingfornativeand try to ping your TAP interface's / bridge's link-local address. The first ping will fail without this commit. With it it will succeed.Issues/PRs references
None