gnrc_icmpv6_error: use dispatch_send() instead of send() #10225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way other threads than `gnrc_ipv6`'s event handling thread can receive these packages (good for debugging and testing ;-)).
|
This change exist also (in a far more involved version) within #8594, so I'm closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This way other threads than
gnrc_ipv6's event handling thread canreceive these packages (good for debugging and testing ;-)).
Testing procedure
Since this module sadly isn't really used (I plan to change that in the future, this is only the first step) only a compile test can verify. Just compile
gnrc_networkingwithUSEMODULE += gnrc_icmpv6_error.Issues/PRs references