doccheck: exclude dist/tools directory from group check #10152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
reviewed
Oct 11, 2018
dist/tools/doccheck/check.sh
Outdated
| @@ -32,7 +32,7 @@ then | |||
| fi | |||
|
|
|||
| exclude_filter() { | |||
| grep -v -e vendor -e examples -e tests | |||
| grep -e vendor -e examples -e tests -e "\<dist/tools\>" | |||
There was a problem hiding this comment.
Leftover from my experimentations with this script. I noticed it already when retesting, but forgot to put it back.
38844c9 to
6f8fd1d
Compare
aabadie
reviewed
Oct 11, 2018
| @@ -32,7 +32,7 @@ then | |||
| fi | |||
|
|
|||
| exclude_filter() { | |||
| grep -v -e vendor -e examples -e tests | |||
| grep -v -e vendor -e examples -e tests -e "\<dist/tools\>" | |||
There was a problem hiding this comment.
second question: why using "\< \>". Note that it also works with just dist/tools
There was a problem hiding this comment.
to exclude corner cases like e.g. absurdist/toolspinner ;-) might also be a good idea to adapt this for the other pattrens if applicable. But that's a task for a different PR.
|
Codacy takes longer than Murdock for a one-line change o_O |
|
Codacy is done, let's go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Removes doc group checks from
dist/tools. Doxygen is not supposed to build that so checking it doesn't make sense.Testing procedure
Take e.g. #10072 and run this fix on it. In current state (0ca02de & 19d0da0) it should fail in current master. It is fixed with this PR.
Issues/PRs references
See #10072 (comment)