Skip to content

cpu/atmega_common: make vera++ happy #19779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

cpu/atmega_common: make vera++ happy #19779

merged 1 commit into from
Jun 30, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented Jun 29, 2023

Contribution description

Vera++ doesn't like #error preprocessor directives without a quoted string afterwards (and also my syntax highlighter doesn't like this as well). So let's add the quotes to have the tools not spooked out.

Testing procedure

Green CI and no vera++ annotations on the changed file.

Issues/PRs references

The vera++ annotations cluttered the source view when reviewing #19777, despite none of the annotations being relevant to the PR changes.

@maribu
cpu/atmega_common: make vera++ happy
87e3a61 
Vera++ doesn't like `#error` preprocessor directives without a quoted
string afterwards (and also my syntax highlighter doesn't like this as
well). So let's add the quotes to have the tools not spooked out.
@maribu maribu requested a review from kYc0o as a code owner June 29, 2023 20:30
@maribu maribu added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jun 29, 2023
@github-actions github-actions bot added Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: cpu Area: CPU/MCU ports and removed Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jun 29, 2023
@maribu maribu mentioned this pull request Jun 29, 2023
Merged
@maribu
Copy link
Member Author

maribu commented Jun 30, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Jun 30, 2023
@riot-ci
Copy link

riot-ci commented Jun 30, 2023

Murdock results

✔️ PASSED

87e3a61 cpu/atmega_common: make vera++ happy

Success Failures Total Runtime
1 0 1 51s

Artifacts

@maribu
Copy link
Member Author

maribu commented Jun 30, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 6fc0064 into RIOT-OS:master Jun 30, 2023
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
@maribu maribu deleted the cpu/atmega_common/make-vera++-happy branch December 5, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandojve nandojve nandojve approved these changes

@kYc0o kYc0o Awaiting requested review from kYc0o kYc0o is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @nandojve @benpicco