stdio_dispatch: allow to select multiple stdio methods at the same time #19738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e03795 to
fe4b248
Compare
miri64
reviewed
Jun 16, 2023
083a0fd to
ae3ae3d
Compare
ae3ae3d to
c5c7fab
Compare
|
This is now ready for review again. |
87ac088 to
3849257
Compare
7d91af4 to
018b732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This implements the option to have multiple stdio methods active at the same time.
This can be useful to allow e.g. remote debugging while also retaining the possibility for local shell access.
To implement this, all
stdinimplementations are expected to write to a commonstdin_isrpipe.Two stdio providers have not been converted to the new interface yet, that means they can't be combined with a second stdio method:
stdio_native: depends on cpu/native: use async read for stdio_read() #19002slipdev_stdio: depends on drivers/slipdev: make use of chunked ringbuffer #18066stdio_ethos: requires a similar patch asslipdev_stdioIf only a single stdio method is used, the function pointer/XFA based interface degrades into the traditional in-place implementations of
stdio_init()/stdio_write()to avoid introducing any overhead in the common case.Testing procedure
It is now possible to select multiple stdio implementations and use them all at the same time:
Issues/PRs references
fixes #13469