Skip to content

sys/usb/usbus_msc: fix typo in C expression #19637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2023
Merged

sys/usb/usbus_msc: fix typo in C expression #19637

merged 1 commit into from
May 21, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented May 20, 2023

Contribution description

Rather than setting the correct blk_len, the code only wrote 1 and 0 into the three bytes due to the use of a logic and where a bitwise and should be used.

Testing procedure

Code review should be sufficient, the issue is pretty obvious in the diff.

Issues/PRs references

Split out of #19634

@maribu
sys/usb/usbus_msc: fix typo in C expression
28c1630 
Rather than setting the correct blk_len, the code only wrote 1 and 0
into the three bytes due to the use of a logic and where a bitwise
and should be used.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Area: USB Area: Universal Serial Bus labels May 20, 2023
@maribu maribu requested a review from MrKevinWeiss May 20, 2023 20:20
@maribu maribu requested review from bergzand, dylad and aabadie as code owners May 20, 2023 20:20
@github-actions github-actions bot added the Area: sys Area: System label May 20, 2023
@maribu maribu mentioned this pull request May 20, 2023
Merged
4 tasks
@riot-ci
Copy link

riot-ci commented May 20, 2023

Murdock results

✔️ PASSED

28c1630 sys/usb/usbus_msc: fix typo in C expression

Success Failures Total Runtime
6946 0 6946 11m:25s

Artifacts

aabadie
aabadie approved these changes May 21, 2023
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie
Copy link
Contributor

aabadie commented May 21, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 21, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a28f6e5 into RIOT-OS:master May 21, 2023
@maribu maribu deleted the usb/msc branch May 24, 2023 19:07
@maribu
Copy link
Member Author

maribu commented May 24, 2023

Thx :)

@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @aabadie @benpicco