Skip to content

tests: move nimble and lwip related to test applications to tests/pkg #19582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2023
Merged

tests: move nimble and lwip related to test applications to tests/pkg #19582

merged 2 commits into from
May 12, 2023

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 12, 2023

Contribution description

As discussed in #19551, nimble and lwip are respectively ble and networking libraries provided as external packages so their test applications should be placed in tests/pkg

Testing procedure

  • Green CI
  • lwip and nimble tests applications are correctly listed by the build system:
$ make info-applications | grep tests/ | grep -E "nimble|lwip"
tests/pkg/lwip
tests/pkg/lwip_sock_ip
tests/pkg/lwip_sock_tcp
tests/pkg/lwip_sock_udp
tests/pkg/nimble_autoconn_ccnl
tests/pkg/nimble_autoconn_gnrc
tests/pkg/nimble_autoconn_gnrc_ext
tests/pkg/nimble_esp_wifi_coexist
tests/pkg/nimble_ext_adv
tests/pkg/nimble_l2cap
tests/pkg/nimble_l2cap_server
tests/pkg/nimble_netif_ext
tests/pkg/nimble_rpble_gnrc
tests/pkg/nimble_rpble_gnrc_ext
tests/pkg/nimble_statconn_gnrc
tests/pkg/nimble_statconn_gnrc_ext

Issues/PRs references

follow-up of #19551

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 12, 2023
@github-actions github-actions bot added Area: build system Area: Build system Area: doc Area: Documentation Area: tests Area: tests and testing framework labels May 12, 2023
@aabadie aabadie mentioned this pull request May 12, 2023
Merged
@riot-ci
Copy link

riot-ci commented May 12, 2023 •
edited
Loading

Murdock results

✔️ PASSED

ab3cfff tests: move lwip* tests to tests/pkg

Success Failures Total Runtime
6931 0 6931 09m:07s

Artifacts

@aabadie aabadie force-pushed the pr/tests/move_some branch 2 times, most recently from b02988a to 8a7f6f6 Compare May 12, 2023 09:07
@maribu
Copy link
Member

maribu commented May 12, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 12, 2023

👎 Rejected by PR status

@aabadie aabadie force-pushed the pr/tests/move_some branch from 8a7f6f6 to ab3cfff Compare May 12, 2023 09:25
@aabadie
Copy link
Contributor Author

aabadie commented May 12, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit ef0e29e into RIOT-OS:master May 12, 2023
@aabadie aabadie deleted the pr/tests/move_some branch May 12, 2023 17:11
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: doc Area: Documentation Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @riot-ci @maribu @benpicco