-
Notifications
You must be signed in to change notification settings - Fork 2.1k
tests: move sys related applications to their own tests/sys/ folder #19566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
86b0ee6
to
63c9c43
Compare
63c9c43
to
afc675a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be better in tests/drivers
.
But IMO we should push this PR throw the moment Murdock is green and handle the nitpicks as follow up. (This would also allow to distribute the workload.)
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this file in tests/core directory ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely a copy paste mistake from the PR that moved the core related tests. Do you mind to PR a fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There you go: #19783
Contribution description
This PR is similar to #19565 but applied to sys related test applications. Note that xtimer, ztimer, evtimer test applications were also moved. Networking related test applications (gnrc_, etc) are not moved (for now). cpp related applications were moved except
cpp_ext
andcpp_exclude
which I consider build system related (another similar PR for that topic to come).After that PR, there will still be more than 100 applications in the
tests/sys
, maybe another level of subdirectories could be added there (for xtimer, ztimer test applications for example).Testing procedure
Green CI
Issues/PRs references
#19565 and the family