Skip to content

tests: move sys related applications to their own tests/sys/ folder #19566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2023

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 10, 2023

Contribution description

This PR is similar to #19565 but applied to sys related test applications. Note that xtimer, ztimer, evtimer test applications were also moved. Networking related test applications (gnrc_, etc) are not moved (for now). cpp related applications were moved except cpp_ext and cpp_exclude which I consider build system related (another similar PR for that topic to come).

After that PR, there will still be more than 100 applications in the tests/sys, maybe another level of subdirectories could be added there (for xtimer, ztimer test applications for example).

Testing procedure

Green CI

Issues/PRs references

#19565 and the family

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 10, 2023
@github-actions github-actions bot added Area: build system Area: Build system Area: doc Area: Documentation Area: tests Area: tests and testing framework labels May 10, 2023
@riot-ci
Copy link

riot-ci commented May 10, 2023

Murdock results

✔️ PASSED

8a7ad8f tests/pkg/tinyusb_cdc_acm_stdio: fix symlink

Success Failures Total Runtime
6931 0 6931 09m:02s

Artifacts

@aabadie aabadie force-pushed the pr/tests/sys_move branch 2 times, most recently from 86b0ee6 to 63c9c43 Compare May 10, 2023 09:40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be better in tests/drivers.

But IMO we should push this PR throw the moment Murdock is green and handle the nitpicks as follow up. (This would also allow to distribute the workload.)

@aabadie
Copy link
Contributor Author

aabadie commented May 10, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 10, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this file in tests/core directory ?

Copy link
Member

@maribu maribu Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely a copy paste mistake from the PR that moved the core related tests. Do you mind to PR a fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go: #19783

@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: doc Area: Documentation Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants