Skip to content

sys: partly refactor make dependency resolution #19492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jun 15, 2023
Merged

sys: partly refactor make dependency resolution #19492

merged 36 commits into from
Jun 15, 2023

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 21, 2023 •
edited
Loading

Contribution description

After the discussion in #19485, I had another look at the dependency resolution in sys (I had time to spend). This (draft) PR is applying a similar approach proposed in #19485 (comment) to other modules (except those in shell, net, usb, ztimer* and xtimer).

It seems the order of resolution might make a difference in the result. This is why I'm opening this PR as a draft PR, to see what the CI has to say.

While doing that, I noticed were not ported to Kconfig yet. This PR also adds some commits for that and could be split out in another PR if requested. merged in #19622

Testing procedure

  • Green CI
  • Same modules included (there's a tool for that but I don't remember which one)

Issues/PRs references

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 21, 2023
@github-actions github-actions bot added Area: arduino API Area: Arduino wrapper API Area: build system Area: Build system Area: Kconfig Area: Kconfig integration Area: OTA Area: Over-the-air updates Area: SAUL Area: Sensor/Actuator Uber Layer Area: sys Area: System Area: timers Area: timer subsystems labels Apr 21, 2023
@aabadie aabadie mentioned this pull request Apr 21, 2023
Merged
@riot-ci
Copy link

riot-ci commented Apr 21, 2023 •
edited
Loading

Murdock results

✔️ PASSED

1826331 sys/usbus: move dependency resolution in its own Makefile.dep

Success Failures Total Runtime
6934 0 6934 12m:02s

Artifacts

@aabadie aabadie force-pushed the pr/sys/shell_deps_cleanup branch from 3e6bb55 to 9c7f5e7 Compare April 21, 2023 10:43
@github-actions github-actions bot added the Area: USB Area: Universal Serial Bus label Apr 21, 2023
@aabadie aabadie force-pushed the pr/sys/shell_deps_cleanup branch from 3b20a90 to f86932e Compare April 21, 2023 14:29
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Apr 22, 2023
@aabadie aabadie force-pushed the pr/sys/shell_deps_cleanup branch from ad4bced to e94dc64 Compare April 22, 2023 10:52
@aabadie aabadie added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: full build disable CI build filter CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 22, 2023
@aabadie aabadie force-pushed the pr/sys/shell_deps_cleanup branch from e94dc64 to 3b40bdf Compare April 22, 2023 15:36
@github-actions github-actions bot removed the Area: tests Area: tests and testing framework label Apr 22, 2023
@aabadie aabadie marked this pull request as ready for review April 22, 2023 16:26
aabadie added 23 commits June 15, 2023 10:24
@aabadie
sys/cpp11-compat: move dependency resolution in its own Makefile.dep
16b2606
@aabadie
sys/schedstatistics: move dependency resolution in its own Makefile.dep
79207fa
@aabadie
sys/sched_round_robin: move deps resolution in its own Makefile.dep
ab61a0f
@aabadie
sys/saul_reg: move dependency resolution in its own Makefile.dep
090ccc5
@aabadie
sys/senml: cleanup dependency resolution
1c57e73
@aabadie
sys/phydat: move dependency resolution in its own Makefile.dep
643c239
@aabadie
sys/pm_layered: move dependency resolution in its own Makefile.dep
9fb5708
@aabadie
sys/can: move dependency resolution in its own Makefile.dep
113200f
@aabadie
sys/entropy_source: move dependency resolution in its own Makefile.dep
50ed85a
@aabadie
sys/puf_sram: move dependency resolution in its own Makefile.dep
db19f6f
@aabadie
sys/random: move dependency resolution in its own Makefile.dep
c8d4256
@aabadie
sys/vfs*: move dependency resolution in its own Makefile.dep
c164007
@aabadie
sys/event: move dependency resolution in its own Makefile.dep
9386e08
@aabadie
sys/benchmark: move dependency resolution in its own Makefile.dep
8256424
@aabadie
sys/uuid: move dependency resolution in its own Makefile.dep
1f4adb2
@aabadie
sys/riotboot: move dependency resolution in its own Makefile.dep
d617d86
@aabadie
sys/suit: move dependency resolution in its own Makefile.dep
9bd7950
@aabadie
sys/fido2: move dependency resolution in its own Makefile.dep
ff4b2d1
@aabadie
sys/uri_parser: move dependency resolution in its own Makefile.dep
6cfafbd
@aabadie
sys/evtimer: move dependency resolution in its own Makefile.dep
bec4c3e
@aabadie
sys/ut_process: move dependency resolution in its own Makefile.dep
d9047a0
@aabadie
sys/congure: move dependency resolution in its own Makefile.dep
03d2792
@aabadie
sys/usbus: move dependency resolution in its own Makefile.dep
1826331
@aabadie aabadie force-pushed the pr/sys/shell_deps_cleanup branch from 442797e to 1826331 Compare June 15, 2023 08:27
@aabadie
Copy link
Contributor Author

aabadie commented Jun 15, 2023

rebase, let's see what Murdock has to say

@aabadie
Copy link
Contributor Author

aabadie commented Jun 15, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 15, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 5d32c95 into RIOT-OS:master Jun 15, 2023
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri

@jia200x jia200x Awaiting requested review from jia200x

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: arduino API Area: Arduino wrapper API Area: build system Area: Build system Area: OTA Area: Over-the-air updates Area: SAUL Area: Sensor/Actuator Uber Layer Area: sys Area: System Area: timers Area: timer subsystems Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @riot-ci @benpicco