sys/bitfield: don't touch unrelated bits in bf_{set, clear}_all() #19400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When I added those functions I thought there was no use-case for not touching the remaining bits of the last byte of the bitfield (e.g. in a bitfield of size 5 a
bf_clear_all()would set all 8 bits of the bitfield-byte to 0).But it turns out there is a use case for only clearing/setting part of a bitfield, so make the
bf_{set, clear}_all()functions actually honor the proper size they are called with.Testing procedure
A new test case has been added to the unit test to check if no unrelated bits are touched.
This test case will fail on
master.Issues/PRs references