Skip to content

cpu/gd32v: add periph_spi support #19214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 1, 2023
Merged

cpu/gd32v: add periph_spi support #19214

merged 7 commits into from
Feb 1, 2023

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jan 30, 2023 •
edited
Loading

Contribution description

This PR provides the periph_spi support and is one of a bunch of PRs that complete the peripheral drivers for GD32VF103.

The driver is a modified version of the driver for STM32F1 with some changes that were necessary to get it working on GD32V.

Testing procedure

tests/periph_spi as well as a test with any SPI sensor should work. tests/driver_sdcard_spi should work on sipeed-longan-nano.

Issues/PRs references

Depeneds on PR #19216

@gschorcht gschorcht changed the title cpu/gd32v: add periph spi support cpu/gd32v: add periph_spi support Jan 30, 2023
@github-actions github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: tools Area: Supplementary tools labels Jan 30, 2023
@gschorcht gschorcht force-pushed the cpu/gd32v/periph_spi branch from 236c16c to dee714d Compare January 30, 2023 07:26
@gschorcht gschorcht requested a review from bergzand January 30, 2023 07:27
@gschorcht gschorcht added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms labels Jan 30, 2023
@riot-ci
Copy link

riot-ci commented Jan 30, 2023 •
edited
Loading

Murdock results

✔️ PASSED

929bb3e dist/tools/doccheck: add ST7735 config to generic_exclude_pattern

Success Failures Total Runtime
6807 0 6807 11m:09s

Artifacts

benpicco
benpicco reviewed Jan 30, 2023
View reviewed changes
@gschorcht gschorcht added the State: waiting for other PR State: The PR requires another PR to be merged first label Jan 30, 2023
@benpicco benpicco removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jan 31, 2023
@github-actions github-actions bot removed the Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms label Jan 31, 2023
@benpicco
Copy link
Contributor

please squash

@gschorcht gschorcht force-pushed the cpu/gd32v/periph_spi branch from a48e2cb to ec66e3e Compare January 31, 2023 20:07
@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 1, 2023

Merge conflict.

@gschorcht gschorcht force-pushed the cpu/gd32v/periph_spi branch from ec66e3e to 929bb3e Compare February 1, 2023 01:45
@gschorcht
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 1, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@gschorcht gschorcht mentioned this pull request Feb 1, 2023
Merged
@benpicco
Copy link
Contributor

benpicco commented Feb 1, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 1, 2023

Build succeeded:

@bors bors bot merged commit cf2d66e into RIOT-OS:master Feb 1, 2023
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/gd32v/periph_spi branch February 1, 2023 19:15
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @riot-ci @benpicco @MrKevinWeiss