Skip to content

boards/sipeed-longan-nano: default to flashing via DFU #19204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

boards/sipeed-longan-nano: default to flashing via DFU #19204

merged 1 commit into from
Jan 27, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

I found it to be more convenient for quick testing to being able to flash the board without the need to wire up an external debugger.
I think it makes sense to have the default set to something that works without needing to wire up an external debugger, if you add a debugger you can also set the appropriate environment variable as there is no debugger anyway.

Testing procedure

Hold the BOOT0 button when pressing RESET.
The board will enter DFU mode and can be flashed without a debugger.

Press RESET again to leave bootloader mode.

Issues/PRs references

@benpicco benpicco requested a review from gschorcht January 27, 2023 10:45
@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation labels Jan 27, 2023
@gschorcht
Copy link
Contributor

I found it to be more convenient for quick testing to being able to flash the board without the need to wire up an external debugger.

Yeah, it wasn't a problem for me since I had an external debug adapter connected for debugging anyway.

gschorcht
gschorcht reviewed Jan 27, 2023
View reviewed changes
@benpicco benpicco force-pushed the boards/sipeed-longan-nano_dfu branch from 4a8c118 to 15dfadd Compare January 27, 2023 11:11
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 27, 2023
gschorcht
gschorcht approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@gschorcht
Copy link
Contributor

gschorcht commented Jan 27, 2023 •
edited
Loading

BTW, tinyUSB is already working for me. Maybe, we can switch to riotboot_dfu including usb_board_reset later.

@riot-ci
Copy link

riot-ci commented Jan 27, 2023

Murdock results

✔️ PASSED

15dfadd boards/sipeed-longan-nano: default to flashing via DFU

Success Failures Total Runtime
6796 0 6796 06m:45s

Artifacts

@benpicco
Copy link
Contributor Author

benpicco commented Jan 27, 2023 •
edited
Loading

I think the ROM DFU bootloader is fine, we'll just have to find out how to trigger a reset to it using software.
I wouldn't be surprised if it worked just like bootloader_stm32.

@gschorcht
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 27, 2023

Build succeeded:

@bors bors bot merged commit a175ad2 into RIOT-OS:master Jan 27, 2023
@benpicco benpicco deleted the boards/sipeed-longan-nano_dfu branch January 27, 2023 17:22
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @gschorcht @riot-ci @MrKevinWeiss