Skip to content

cpu/esp{32,8266}/periph_timer: allow changing callback or freq [backport 2022.10] #18973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2022
Merged

cpu/esp{32,8266}/periph_timer: allow changing callback or freq [backport 2022.10] #18973

merged 2 commits into from
Nov 25, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 25, 2022

Backport of #18971

Contribution description

Allow multiple calls to timer_init(), as this is the only way to change the timer frequency or the callback function.

Testing procedure

The test in #18963 should now pass.

Issues/PRs references

#18963

@maribu maribu requested a review from gschorcht as a code owner November 25, 2022 07:26
@maribu maribu added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 25, 2022
@maribu maribu mentioned this pull request Nov 25, 2022
Merged
@maribu maribu removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 25, 2022
@maribu
Copy link
Member Author

maribu commented Nov 25, 2022 •
edited
Loading

TODO: Wait for #18972 to be merged, then rebase, then trigger CI

@maribu maribu mentioned this pull request Nov 25, 2022
Merged
kaspar030
kaspar030 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport ACK.

@kaspar030 kaspar030 enabled auto-merge November 25, 2022 07:54
@maribu
cpu/esp32/periph_timer: allow changing callback or freq
55d9d3c 
Allow multiple calls to timer_init(), as this is the only way to
change the timer frequency or the callback function.

(cherry picked from commit e8fd655)
@maribu
cpu/esp8266/periph_timer: allow changing callback or freq
1b08eb3 
Allow multiple calls to timer_init(), as this is the only way to
change the timer frequency or the callback function.

(cherry picked from commit 03b7fe8)
@maribu maribu force-pushed the backport/2022.10/cpu/esp branch from 2715978 to 1b08eb3 Compare November 25, 2022 11:48
@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 25, 2022
@riot-ci
Copy link

riot-ci commented Nov 25, 2022

Murdock results

✔️ PASSED

1b08eb3 cpu/esp8266/periph_timer: allow changing callback or freq

Success Failures Total Runtime
115836 0 115836 01h:59m:29s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@kaspar030 kaspar030 merged commit dacd4b0 into RIOT-OS:2022.10-branch Nov 25, 2022
@maribu maribu deleted the backport/2022.10/cpu/esp branch November 25, 2022 16:29
@maribu
Copy link
Member Author

maribu commented Nov 25, 2022

thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @riot-ci @kaspar030