Skip to content

rust: Update dependencies, build and test more on stable #18678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2022
Merged

rust: Update dependencies, build and test more on stable #18678

merged 4 commits into from
Oct 2, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Oct 1, 2022 •
edited
Loading

Contribution description

This is a bit more than the usual "bump dependencies", as it also reaps the benefits from the latest crate updates:

  • The overrides that say "we take riot-sys and riot-wrappers from git" are commented out. This results in builds (especially those of the imminent release) will thus fetch code from crates.io only, and not resort to direct git fetching. I consider this fitting for a release, see also Rust: describe that crate versions should be bent away from git Release-Specs#251. If updates need to be done during the next release cycle that require quick fixes, the lines can just be enabled again in the same commit that then also does the cargo update that is necessary to apply the updates into the Cargo.lock files anyway.
  • Tests can be run on stable.
  • Examples are prepared to run on stable (which for native means that the panic=abort setting needs to be added to Cargo.toml, for otherwise nightly-only features would be required)
  • The hello-world example is run on stable.
    This could have been done before, but was not, because users often build on a simple example when exploring advanced things, and there might have been frustration when the advanced things don't work there. Given that barely any riot-wrappers features require nightly any more, this is fine now.
  • rust-gcoap is prepared to be run on stable. It can't right now, but users who have beta installed can already run it.

Testing procedure

  • Green CI (I'm throwing in run-tests too)

Issue references

By running tests on stable this closes #18500

chrysn added 3 commits October 1, 2022 21:29
@chrysn
rust: Update dependencies
399e25c 
This pulls in versions of previously nightly-only crates that can be
built on 1.65 beta.

The Cargo overrides that direct the resolver to the git repositories are
disabled while the version used in tree also happens to be a released
version of the crates, as it should be the case as per [251].

[251]: RIOT-OS/Release-Specs#251
@chrysn
rust: Run all tests on stable
22e46eb 
Closes: RIOT-OS#18500
@chrysn
rust: Set panic=abort on path towards building on stable
8a61ed1
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Area: Rust Area: Rust wrapper labels Oct 1, 2022
@github-actions github-actions bot added Area: examples Area: Example Applications Area: sys Area: System Area: tests Area: tests and testing framework labels Oct 1, 2022
@chrysn
Copy link
Member Author

chrysn commented Oct 1, 2022 •
edited
Loading

I've added one more commit that sets -Os and -lto on Rust code, which gets the code size from 87KiB to 57KiB on the rust-gcoap example. This hopefully counteracts other effects I couldn't pinpoint yet that let the binary size grow to the point where it exceeded some boards' capacities.

[edit: Numbers are on microbit-v2. Before this PR, Rust code size was 46KiB, so chances are I'll still need to investigate why things grew that dramatically]

@chrysn
Copy link
Member Author

chrysn commented Oct 2, 2022

The size increases is due to coap-message-demo's newly gained CBOR serialization and deserialization default handlers (two new demo resources); the rest of the changes did not significantly impact the sizes. Just flicking on some optimizations allowed leaving the list of supported boards as-is. At some point we'll have to reconsider which examples we can pack in, and/or whether there are demos that are shed under flash pressure, but right now, they still fit.

Unless reviewers disagree, I wouldn't try to remove features from coap-handler-demos (it's not possible right now, but then again I'm maintaining that), and leave the optimization flags in (as they do make a good example case).

@chrysn chrysn added this to the Release 2022.10 milestone Oct 2, 2022
@chrysn chrysn mentioned this pull request Oct 2, 2022
Merged
@chrysn chrysn merged commit b31eb6b into RIOT-OS:master Oct 2, 2022
@chrysn chrysn deleted the rust-update-20221001 branch October 2, 2022 16:10
@chrysn chrysn mentioned this pull request Oct 3, 2022
Merged
@chrysn chrysn mentioned this pull request Nov 24, 2022
Closed
@chrysn chrysn mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@benpicco benpicco Awaiting requested review from benpicco

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: Rust Area: Rust wrapper Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.

Modules implemented in Rust should build on stable Rust
2 participants
@chrysn @maribu