Skip to content

cpu/sam0_common: adc: drop pin from adc_conf_chan_t #18658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2022
Merged

cpu/sam0_common: adc: drop pin from adc_conf_chan_t #18658

merged 2 commits into from
Sep 28, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

The .pin member is no longer used and the .muxpos member is much more than just MUXPOS now - so drop the .pin and while we change the API anyway, also rename .muxpos.

Testing procedure

Issues/PRs references

follow-up to #18146

@github-actions github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Sep 27, 2022
dylad
dylad requested changes Sep 27, 2022
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a mistake.
Feels free to squash right away

dylad
dylad approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 27, 2022
@benpicco benpicco added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label Sep 27, 2022
@benpicco
Copy link
Contributor Author

Thank you for the quick review!

@benpicco benpicco merged commit 81a00f0 into RIOT-OS:master Sep 28, 2022
@benpicco benpicco deleted the cpu/sam0_adc-rework branch September 28, 2022 15:27
@benpicco benpicco added this to the Release 2022.10 milestone Sep 28, 2022
@benpicco benpicco mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylad dylad dylad approved these changes

@keestux keestux Awaiting requested review from keestux keestux is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
2 participants
@benpicco @dylad