Skip to content

dns_cache: handle TTL=0 properly #18441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2022
Merged

dns_cache: handle TTL=0 properly #18441

merged 2 commits into from
Aug 23, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Aug 11, 2022

Contribution description

Existing entries should be expired, new entries should not be created.

Testing procedure

I added a test case for TTL=0 to the unittests, so

make -C tests/unittests/ tests-dns_cache test

should succeed.

Issues/PRs references

miri64 added 2 commits August 11, 2022 14:04
@miri64
dns_cache: handle TTL=0 properly
883c3fd 
Existing entries should be expired, new entries should not be created.
@miri64
tests/unittests/tests-dns_cache: add test case for TTL=0
7d2c4c4
@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Aug 11, 2022
@miri64 miri64 requested a review from benpicco August 11, 2022 12:08
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Aug 11, 2022
@miri64
Copy link
Member Author

miri64 commented Aug 11, 2022

See also RFC 1035 on that:

TTL             a 32 bit unsigned integer that specifies the time
                interval (in seconds) that the resource record may be
                cached before it should be discarded.  Zero values are
                interpreted to mean that the RR can only be used for the
                transaction in progress, and should not be cached.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 11, 2022
@miri64 miri64 enabled auto-merge August 11, 2022 13:33
@MrKevinWeiss MrKevinWeiss mentioned this pull request Aug 12, 2022
Closed
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 22, 2022
@miri64 miri64 merged commit f15fbb3 into RIOT-OS:master Aug 23, 2022
@miri64 miri64 deleted the dns_cache/fix/ttl0 branch August 29, 2022 06:29
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @benpicco @maribu