Skip to content

cpu/esp32: add ESP32-S3 support to makefiles #18410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2022
Merged

cpu/esp32: add ESP32-S3 support to makefiles #18410

merged 2 commits into from
Aug 10, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR is a split-off from #18185 and adds the support of ESP32-S3 to the makefiles.

Testing procedure

Green CI

Issues/PRs references

Split-off from #18185

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Aug 7, 2022
@gschorcht gschorcht added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 7, 2022
@gschorcht gschorcht force-pushed the cpu/esp32/add_esp32s3_makefiles branch from ccb77ea to b355ef4 Compare August 8, 2022 04:36
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 8, 2022
@gschorcht gschorcht requested a review from benpicco August 9, 2022 04:44
@gschorcht gschorcht force-pushed the cpu/esp32/add_esp32s3_makefiles branch from b355ef4 to bfbaee5 Compare August 9, 2022 05:07
@gschorcht gschorcht mentioned this pull request Aug 9, 2022
Merged
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 9, 2022
@chrysn chrysn mentioned this pull request Aug 9, 2022
Merged
@gschorcht gschorcht mentioned this pull request Aug 9, 2022
Closed
@gschorcht gschorcht force-pushed the cpu/esp32/add_esp32s3_makefiles branch from bfbaee5 to 2902a9a Compare August 9, 2022 13:57
benpicco
benpicco approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't have minded keeping this with the rest, so it can be compile tested.

But code looks good.

@benpicco benpicco enabled auto-merge August 9, 2022 20:09
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 10, 2022
@gschorcht
Copy link
Contributor Author

Unfortunately, again an unrelated hash mismatch error, so I restarted the CI build with the label 'CI: skip compile test' to avoid unecessary CI load.

@benpicco benpicco merged commit dff1f68 into RIOT-OS:master Aug 10, 2022
@gschorcht gschorcht deleted the cpu/esp32/add_esp32s3_makefiles branch August 17, 2022 00:09
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @benpicco @chrysn @maribu