Skip to content

tests/ieee802154_*: fix tx_done handler on ACK_TIMEOUT and improve tests #18382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2022
Merged

tests/ieee802154_*: fix tx_done handler on ACK_TIMEOUT and improve tests #18382

merged 3 commits into from
Jul 28, 2022

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented Jul 28, 2022

Contribution description

This PR takes over original work by @MichelRottleuthner and does essentially 3 things:

  1. It fixes a missing call to ieee802154_set_rx on TX_DONE if the radio supports ACK_TIMEOUT or FRAME_RETRANS.
  2. It adds support for ACK_REQ flag in tests/ieee802154_hal
  3. It indicates the received packet length in tests/ieee802154_submac

Testing procedure

  1. Make sure tests/ieee802154_hal works as expected and try sending messages with and without ACK_REQ:
txtsnd <ext_addr> <len> ack_req
txtsnd <ext_addr> <len>
  1. Make sure tests/ieee802154_submac works as expected and displays the received packet length.

Issues/PRs references

None so far, but it will be required for the KW2xRF Radio HAL port

jia200x and others added 3 commits July 28, 2022 18:41
@jia200x @MichelRottleuthner
tests/ieee802154_hal: add support for ack_req flag
8d54da1 
Co-authored-by: Michel Rottleuthner <michel.rottleuthner@haw-hamburg.de>
@jia200x @MichelRottleuthner
tests/ieee802154_submac: indicate packet length on rx_done
63af1a0 
Co-authored-by: Michel Rottleuthner <michel.rottleuthner@haw-hamburg.de>
@jia200x
tests/ieee802154_hal: fix missing rx_on on ack_timeout
48d6f53
@jia200x jia200x requested a review from PeterKietzmann July 28, 2022 16:43
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jul 28, 2022
@jia200x jia200x mentioned this pull request Jul 28, 2022
Merged
benpicco
benpicco approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 28, 2022
@benpicco benpicco merged commit 35d2af3 into RIOT-OS:master Jul 28, 2022
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
3 participants
@jia200x @benpicco @maribu