Skip to content

boards/stm32f469i-disco: LEDX_ON LEDX_OFF mismatch #18041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

During tests of stm32f469i-disco I noticed that LEDX_ON and LEDX_OFF macros are mismatched.

When I looked at board manual I found that in this board LEDs are on using low signal - 4.15 Buttons and LEDs, "To light a LED a low logic state 0 should be written in the corresponding GPIO". Most (all?) STM Nucleo boards use for this purpose high signal, for example, the f429zi, 6.5 LEDs, "These user LEDs are on when the I/O is HIGH value, and are off when the I/O is LOW."

This PR fix this issue.

Testing procedure

Without PR, this sample program switch all four LEDs on.

#include "led.h"

int main(void)
{
 LED0_OFF;
 LED1_OFF;
 LED2_OFF;
 LED3_OFF;

 return 0;
}

With this PR everything is OK - LEDs remain off.

Issues/PRs references

None

@github-actions github-actions bot added the Area: boards Area: Board ports label May 2, 2022
@krzysztof-cabaj krzysztof-cabaj force-pushed the stm32f469i-disco-LEDs branch from cf2591c to 3f49e9b Compare May 2, 2022 09:07
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 2, 2022
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@benpicco benpicco enabled auto-merge May 2, 2022 10:15
@benpicco benpicco merged commit dd2d8a4 into RIOT-OS:master May 2, 2022
@krzysztof-cabaj krzysztof-cabaj deleted the stm32f469i-disco-LEDs branch May 2, 2022 10:29
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants