Skip to content

pkg/jerryscript: model in Kconfig #18012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2022
Merged

pkg/jerryscript: model in Kconfig #18012

merged 2 commits into from
Apr 27, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 26, 2022

Contribution description

Another Kconfig dependency modelling, this time for the jerryscript package.

Testing procedure

Green Murdock

Issues/PRs references

None

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 26, 2022
@github-actions github-actions bot added Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports labels Apr 26, 2022
@aabadie aabadie changed the title pkg/jerrycript: model in Kconfig pkg/jerryscript: model in Kconfig Apr 26, 2022
leandrolanzieri
leandrolanzieri reviewed Apr 27, 2022
View reviewed changes
@aabadie aabadie force-pushed the pr/pkg/jerrycript_kconfig branch from 3109c87 to ad94965 Compare April 27, 2022 09:08
leandrolanzieri
leandrolanzieri approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ACK

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 27, 2022
@aabadie aabadie enabled auto-merge April 27, 2022 10:51
@aabadie aabadie merged commit 9538b88 into RIOT-OS:master Apr 27, 2022
@aabadie aabadie deleted the pr/pkg/jerrycript_kconfig branch April 27, 2022 17:10
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
@aabadie aabadie mentioned this pull request May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @leandrolanzieri @chrysn