Skip to content

pkg/fatfs: fix missing mutex header #17865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

pkg/fatfs: fix missing mutex header #17865

merged 2 commits into from
Mar 25, 2022

Conversation

jue89
Copy link
Contributor

@jue89 jue89 commented Mar 25, 2022

Contribution description

If fatfs_vfs_format is built with CONFIG_FATFS_FORMAT_ALLOC_STATIC=1, mutex headers are missing.

Testing procedure

Compile tests/pkg_fatfs_vfs.

Issues/PRs references

@jue89 jue89 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: fs Area: File systems labels Mar 25, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Mar 25, 2022
benpicco
benpicco reviewed Mar 25, 2022
View reviewed changes
@jue89 jue89 force-pushed the fix/fatfs_vfs_format_mutex branch from 494c62d to 67fc797 Compare March 25, 2022 16:40
@jue89 jue89 enabled auto-merge March 25, 2022 16:43
@jue89
Copy link
Contributor Author

jue89 commented Mar 25, 2022

Thank you :)

@jue89 jue89 mentioned this pull request Mar 25, 2022
Merged
@jue89 jue89 merged commit 77dfa47 into RIOT-OS:master Mar 25, 2022
@jue89 jue89 deleted the fix/fatfs_vfs_format_mutex branch March 26, 2022 15:19
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: fs Area: File systems Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@jue89 @benpicco @OlegHahm