Skip to content

drivers/mrf24j40: move CFLAG to Makefile.include #17792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

drivers/mrf24j40: move CFLAG to Makefile.include #17792

merged 1 commit into from
Mar 11, 2022

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

CFLAGS should be added in Makefile.includes. For mrf24j40 it was being done in Makefile.dep, so this corrects it.

Testing procedure

  • Green CI
  • Check that the external PA CFLAG is set when not using mrf24j40ma but other variant

Issues/PRs references

Split from #17789

@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 11, 2022
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Mar 11, 2022
@leandrolanzieri leandrolanzieri mentioned this pull request Mar 11, 2022
Merged
@leandrolanzieri leandrolanzieri added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 11, 2022
bergzand
bergzand approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ack, don't have the radio with PA to test this

@leandrolanzieri
Copy link
Contributor Author

All green!

@bergzand bergzand merged commit 2c9811c into RIOT-OS:master Mar 11, 2022
@leandrolanzieri
Copy link
Contributor Author

Thanks!

@leandrolanzieri leandrolanzieri deleted the drivers/mrf24j40/move_cflag branch March 11, 2022 12:11
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @bergzand @OlegHahm