{examples,tests}/rust: Rust updates (-sys/-wrappers version, stable) #17761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
approved these changes
Mar 7, 2022
|
Please squash! |
|
If it's OK with you I'll add one more |
On microbit-v2, getting .well-known/core would otherwise result in a stack overflow. Consequently, some boards were removed from the list of supported boards as the currently required RAM exceeds their capacity.
|
The first quashed push was erroneous as it still had a local override in place -- would probably have gone through just fine, and worked, but that would have circumvented the checks that are in place in Cargo.lock against crates.io corruption. The new is good (as can be seen by loading the Cargo.toml diffs -- they show changed versions and hashes but nothing structural), and awaiting Murdock's OK to go through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Another round of updates to the Rust examples, with the usual steps of
with extas of
Disabling default-features on two examples sits somewhere between them -- the deprecation note says only that we have to pull in those that were default so far, but it is necessary to make things work on stable unmodified.
Testing procedure
make all term CARGO_CHANNEL=stable BOARD=microbit-v2 all flash term -C examples/rust-hello-world(if you have Rust 1.59 at hand and all the relevant targets installed)Issues/PRs references
Closes #17526
Includes a cherry-pick from #17554
Once this is through, I can open one at https://arewertosyet.com/ to make our "compiles on stable" checkbox go green.