Skip to content

drivers: model kconfig for Ethernet drivers #17739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 25, 2022
Merged

drivers: model kconfig for Ethernet drivers #17739

merged 12 commits into from
Jul 25, 2022

Conversation

leandrolanzieri
Copy link
Contributor

@leandrolanzieri leandrolanzieri commented Mar 3, 2022 •
edited
Loading

Contribution description

This models all Ethernet drivers in Kconfig. To test this (and also to make tests stack-independent) all related test applications are modified to run only using netdev (note that to test with GNRC we still have tests/driver_netdev_common). Additionally, specific test applications for stm32_eth and esp_eth are added.

Note: For now this includes some extra changes (e.g., 4b30314, fd9466b, 8da03c2) that most likely will be split.

Testing procedure

  • Green CI

Issues/PRs references

#17744
#17745
#17746
#17747

@leandrolanzieri leandrolanzieri added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Mar 3, 2022
@github-actions github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Mar 3, 2022
This was referenced Mar 4, 2022
Merged
Merged
Merged
Merged
@MrKevinWeiss
Copy link
Contributor

Hmm seems to be some xtimer/ztimer issues...

@leandrolanzieri leandrolanzieri force-pushed the drivers/model_kconfig_eth branch from d587b1c to 3d8b979 Compare April 7, 2022 13:17
@leandrolanzieri
Copy link
Contributor Author

Hmm seems to be some xtimer/ztimer issues...

It was my fault, poor rebasing. Let's see now

@leandrolanzieri
Copy link
Contributor Author

Seems to work

@MrKevinWeiss
Copy link
Contributor

Any blockers? This only touches kconfig so it should be fine if it green. @maribu ?

@leandrolanzieri leandrolanzieri force-pushed the drivers/model_kconfig_eth branch from 3d8b979 to d4233e5 Compare July 25, 2022 08:24
MrKevinWeiss
MrKevinWeiss approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the coding side. Lets see what murdock says then please remove the limiting build commit. ACK.

@leandrolanzieri leandrolanzieri force-pushed the drivers/model_kconfig_eth branch from d4233e5 to 5b3936d Compare July 25, 2022 08:48
@github-actions github-actions bot removed the Area: CI Area: Continuous Integration of RIOT components label Jul 25, 2022
@leandrolanzieri leandrolanzieri force-pushed the drivers/model_kconfig_eth branch from 5b3936d to 1716638 Compare July 25, 2022 09:08
@leandrolanzieri
Copy link
Contributor Author

Fixed whitespace issue

@MrKevinWeiss MrKevinWeiss merged commit aa268f0 into RIOT-OS:master Jul 25, 2022
@MrKevinWeiss
Copy link
Contributor

Finally eh?

@leandrolanzieri leandrolanzieri deleted the drivers/model_kconfig_eth branch July 25, 2022 12:26
This was referenced Aug 2, 2022
Merged
Merged
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
@aabadie aabadie mentioned this pull request May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu left review comments

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@benpicco benpicco Awaiting requested review from benpicco

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@dylad dylad Awaiting requested review from dylad

@keestux keestux Awaiting requested review from keestux

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: native Platform: This PR/issue effects the native platform Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
7 participants
@leandrolanzieri @MrKevinWeiss @fjmolinas @benpicco @maribu @gschorcht @chrysn