Skip to content

boards/native: select MTD defaults for FAT #17653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2022
Merged

boards/native: select MTD defaults for FAT #17653

merged 3 commits into from
Feb 15, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

The FAT file system makes some strong assumptions about sector and block size that are not met by the default native MTD emulation.

To avoid this trip hazard, change the native MTD defaults when FAT is used.

Testing procedure

The tests still work without overwriting the default values.

Issues/PRs references

@benpicco
boards/native: select MTD defaults for FAT
5f1dda0 
The FAT file system makes some strong assumptions about sector and
block size that are not met by the default native MTD emulation.

To avoid this trip hazard, change the native MTD defaults when FAT is
used.
@benpicco
tests/pkg_fatfs*: don't overwrite native MTD defaults
315342e
@github-actions github-actions bot added Area: boards Area: Board ports Area: tests Area: tests and testing framework Platform: native Platform: This PR/issue effects the native platform labels Feb 14, 2022
@benpicco benpicco requested a review from chrysn February 14, 2022 14:13
@benpicco benpicco added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Feb 14, 2022
@chrysn chrysn mentioned this pull request Feb 14, 2022
Merged
@chrysn
Copy link
Member

chrysn commented Feb 14, 2022

Tested and works. (Without this patch, and when the MTD sizes are not adjusted, mounting panics).

The examples/filesystem/README.md could be simplified now that this is automated.

@chrysn chrysn added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Feb 14, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 14, 2022
@benpicco benpicco requested a review from jia200x as a code owner February 14, 2022 17:23
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 14, 2022
@github-actions github-actions bot added Area: doc Area: Documentation Area: examples Area: Example Applications labels Feb 14, 2022
chrysn
chrysn approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks.

You may want to rebase the fat formatting onto this to address #14430 (comment) without the unavoidable conflict.

@chrysn chrysn merged commit 1c3a646 into RIOT-OS:master Feb 15, 2022
@benpicco benpicco deleted the cpu/native-fatfs_defaults branch February 15, 2022 09:13
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysn chrysn chrysn approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation Area: examples Area: Example Applications Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @chrysn @OlegHahm