Skip to content

sys/net/nanocoap: allow for zero-copy payload response #17559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

sys/net/nanocoap: allow for zero-copy payload response #17559

wants to merge 17 commits into from

Conversation

benpicco
Copy link
Contributor

Contribution description

We don't want to copy the payload into a separate buffer together with the CoAP header when sending.
Instead make use of sock_udp_sendv() and use two packet snips, one for the header and one for the payload.

Testing procedure

examples/nanocoap_server still works, but now the response to "/riot/board" is no longer copied into the reply buffer, but just referenced.

Issues/PRs references

depends on and inludes
#17544
#17485

benpicco added 17 commits January 10, 2022 15:49
@benpicco
sys/net/gnrc_pktbuf: add gnrc_pktbuf_add_tail()
5ab1165
@benpicco
sys/net/sock: add sock_udp_sendv() API
bfcb300
@benpicco
sys/net/grnc: implement sock_udp_sendv_aux()
97a4fb6
@benpicco
pkg/openwsn/sock: implement sock_udp_sendv_aux()
e226495
@benpicco
pkg/lwip: implement sock_udp_sendv_aux()
46ce6ec
@benpicco
test/gnrc_udp: add test for sock_udp_sendv()
2660706
@benpicco
tests/lwip_sock_udp: add test for sock_udp_sendv()
eb8e7a2
@benpicco
fixup! pkg/lwip: implement sock_udp_sendv_aux()
1bad89c
@benpicco
fixup! sys/net/grnc: implement sock_udp_sendv_aux()
7a5a5a3
@benpicco
fixup! fixup! pkg/lwip: implement sock_udp_sendv_aux()
5cb7ee8
@benpicco
fixup! pkg/openwsn/sock: implement sock_udp_sendv_aux()
aad8853
@benpicco
sys/net/nanocoap: Introduce coap_rsp_pkt_t and use it
4fd56e7
@benpicco
net/gcoap: introduce and use gcoap_resource_t
6e0db69
@benpicco
sys/net/nanocoap: use coap_rsp_pkt_t in coap_blockwise_put_bytes()
da38ef0
@benpicco
sys/net/nanocoap: allow for zero-copy payload
05db161
@benpicco
Merge branch 'sock_udp_sendv' into nanocoap-zero_copy_response
5b999ce
@benpicco
fixup! sys/net/nanocoap: allow for zero-copy payload
f52c5bc
@benpicco benpicco added State: demonstrator State: This PR (loosely) demonstrates a concept and is not necessarily meant to be merged. State: waiting for other PR State: The PR requires another PR to be merged first labels Jan 24, 2022
@github-actions github-actions bot added the Area: CoAP Area: Constrained Application Protocol implementations label Jan 24, 2022
@github-actions github-actions bot added Area: examples Area: Example Applications Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Jan 24, 2022
@benpicco benpicco mentioned this pull request Jan 31, 2022
Closed
2 tasks
@benpicco
Copy link
Contributor Author

superseded by #17958

@benpicco benpicco closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@maribu maribu Awaiting requested review from maribu maribu is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: examples Area: Example Applications Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework State: demonstrator State: This PR (loosely) demonstrates a concept and is not necessarily meant to be merged. State: waiting for other PR State: The PR requires another PR to be merged first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benpicco