-
Notifications
You must be signed in to change notification settings - Fork 2.1k
sys/fido2: model Kconfig #17435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/fido2: model Kconfig #17435
Conversation
Hey @leandrolanzieri would you mind taking a look ? |
@leandrolanzieri I noticed that modeling KConfig for |
What do you mean that it 'breaks the configurability'? |
Nvm. Executing |
@leandrolanzieri Anything else to change or does it look fine now? |
@Ollrogge I tested locally and found one missing package and one module discrepancy, comparing to the Makefile dependency resolution:
The following patch should solve both issues: diff --git a/pkg/Kconfig b/pkg/Kconfig
index ece75a5525..66ed1644b5 100644
--- a/pkg/Kconfig
+++ b/pkg/Kconfig
@@ -19,6 +19,7 @@ rsource "elk/Kconfig"
rsource "emlearn/Kconfig"
rsource "esp8266_sdk/Kconfig"
rsource "fff/Kconfig"
+rsource "fido2_tests/Kconfig"
rsource "gecko_sdk/Kconfig"
rsource "gemmlowp/Kconfig"
rsource "hacl/Kconfig"
diff --git a/pkg/fido2_tests/Kconfig b/pkg/fido2_tests/Kconfig
new file mode 100644
index 0000000000..9648b31c7d
--- /dev/null
+++ b/pkg/fido2_tests/Kconfig
@@ -0,0 +1,4 @@
+config PACKAGE_FIDO2_TESTS
+ bool "FIDO2 tests"
+ help
+ Test suite for FIDO2, U2F, and other security key functions.
diff --git a/tests/sys_fido2_ctap/app.config.test b/tests/sys_fido2_ctap/app.config.test
index 04d26692af..5d3f10b646 100644
--- a/tests/sys_fido2_ctap/app.config.test
+++ b/tests/sys_fido2_ctap/app.config.test
@@ -4,3 +4,10 @@ CONFIG_MODULE_FIDO2=y
CONFIG_MODULE_FIDO2_CTAP=y
CONFIG_MODULE_FIDO2_CTAP_TRANSPORT=y
CONFIG_MODULE_FIDO2_CTAP_TRANSPORT_HID=y
+
+CONFIG_PACKAGE_FIDO2_TESTS=y
+
+# Should be autoselecting the MODULE_PRNG_HWRNG if possible
+# Since the makefile cannot we have to override until end of migration
+# Remove when TEST_KCONFIG is complete
+CONFIG_MODULE_PRNG_MUSL_LCG=y Feel free to squash everything directly. |
c44eb37
to
1dde2cd
Compare
Applied your patch and squashed :) |
Let's see what Murdock says |
Looks good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Thanks @Ollrogge for this! |
Thanks for the help ! |
Contribution description
This models Kconfig for the FIDO2 implementation.
Testing procedure
Run
tests/sys_fido2_ctap
withTEST_KCONFIG=1
.