drivers/atwinc15x0: migrate to ztimer #17381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
reviewed
Dec 11, 2021
| #define ATWINC15X0_WAIT_TIMEOUT (20) | ||
| #define ATWINC15X0_WAIT_RECONNECT (5 * US_PER_SEC) | ||
| #define ATWINC15X0_WAIT_RECONNECT_S (5) |
There was a problem hiding this comment.
Why not ms precision here ? This would allow to only have to use ztimer_msec.
There was a problem hiding this comment.
I thought that ztimer_secisn't a problem at all.
There was a problem hiding this comment.
Ok, if you only use ztimer_msec you need less resources of course.
|
Please squash! |
e5c3c88 to
c6874df
Compare
|
@aabadie Thansks for reviewing and setting the auto-merge option 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR migrates the
atwinc15x0driver to ztimer.Testing procedure
should still work.
Issues/PRs references