Skip to content

sys/benchmark/kconfig: cleanup ztimer dependency #17317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2021
Merged

sys/benchmark/kconfig: cleanup ztimer dependency #17317

merged 2 commits into from
Dec 2, 2021

Conversation

gschorcht
Copy link
Contributor

Contribution description

While the makefile dependencies ensure that the ztimer_usec module is pulled in when the benchmark module is used

RIOT/sys/Makefile.dep

Lines 574 to 576 in 48e71b2

ifneq (,$(filter benchmark,$(USEMODULE)))
USEMODULE += ztimer_usec
endif
this is not the case in Kconfig and the application using the benchmark module must explicitly select the ztimer_usec module.

Since the benchmark module definitely needs ztimer_usec, the ztimer_usec module should be selected automatically when the benchmark module is used.

Testing procedure

Compilation of

TEST_KCONFIG=1 make BOARD=nucleo-f103rb -C tests/periph_gpio

should work.

Issues/PRs references

Kconfig for the benchmark module was provided by PR #17126

@gschorcht
sys/benchmark/kconfig: cleanup ztimer dependency
83e9fdc
@gschorcht
tests/periph_gpio: cleanup ztimer dependency
d13da37 
Module benchmark already pulls in ztimer_usec. It is not necessary to pull it in again in application.
@gschorcht gschorcht added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 2, 2021
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework labels Dec 2, 2021
@gschorcht gschorcht added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation and removed Area: tests Area: tests and testing framework labels Dec 2, 2021
leandrolanzieri
leandrolanzieri approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Dec 2, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Dec 2, 2021
@leandrolanzieri leandrolanzieri merged commit 58b3c07 into RIOT-OS:master Dec 2, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Dec 2, 2021
Merged
@gschorcht
Copy link
Contributor Author

Thanks.

@gschorcht gschorcht deleted the sys/benchmark/kconfig/cleanup_ztimer_dependency branch December 2, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
2 participants
@gschorcht @leandrolanzieri