Skip to content

drivers/sx126x/Kconfig: rework model selection #17289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

drivers/sx126x/Kconfig: rework model selection #17289

merged 1 commit into from
Nov 30, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

Split from #17232. This rework how sx126x driver modules are selected, making the entry-point the driver module and using a choice for model selection, in combination with features to default to the correct option.

Testing procedure

  • Check that the new model makes sense and shows up correctly in menuconfig
  • Green CI

Issues/PRs references

#17232

@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 29, 2021
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: tests Area: tests and testing framework labels Nov 29, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 29, 2021
Merged
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 29, 2021
fjmolinas
fjmolinas approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, if Murdock is green lets merge.

@gschorcht gschorcht merged commit 8794b35 into RIOT-OS:master Nov 30, 2021
@leandrolanzieri leandrolanzieri deleted the pr/drivers/sx126x/kconfig/rework branch November 30, 2021 08:40
@leandrolanzieri
Copy link
Contributor Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @fjmolinas @gschorcht