Skip to content

sys/vfs: model Kconfig #17287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2021
Merged

sys/vfs: model Kconfig #17287

merged 2 commits into from
Dec 3, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

Split from #17232. This models the VFS module, include native's, in Kconfig. I added the configuration file for tests/vfs_plus_stdio.

Testing procedure

  • Check the modelling
  • Green CI

Issues/PRs references

#17232

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework Platform: native Platform: This PR/issue effects the native platform labels Nov 29, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 29, 2021
@leandrolanzieri leandrolanzieri mentioned this pull request Nov 29, 2021
Merged
@fjmolinas
Copy link
Contributor

Have you taken a look at modeling all the fs pkgs? It would be good to see how they all fit in together. No a reason to block though.

@leandrolanzieri
Copy link
Contributor Author

Have you taken a look at modeling all the fs pkgs? It would be good to see how they all fit in together. No a reason to block though.

Not yet. I think fatfs provides an interface to vfs but it's an extra module, which would depend on this I'd say. Same goes for constfs and devfs.

fjmolinas
fjmolinas approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fjmolinas fjmolinas enabled auto-merge November 29, 2021 13:15
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 29, 2021
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 30, 2021
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 3, 2021
@fjmolinas fjmolinas merged commit 1ec9bfd into RIOT-OS:master Dec 3, 2021
@leandrolanzieri
Copy link
Contributor Author

Thanks for reviewing and merging!

@leandrolanzieri leandrolanzieri deleted the pr/sys/vfs/model_kconfig branch December 3, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

@gschorcht gschorcht Awaiting requested review from gschorcht

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
4 participants
@leandrolanzieri @fjmolinas @kaspar030 @gschorcht