sys/posix/socket: align struct sockaddr{,_storage} #17152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27f7681 to
1e99b07
Compare
This brings MIPS back in line with the other archs.
RIOT switched to C11, so packages need to follow suit to use RIOT's headers.
Align the first member of `struct sockaddr` and `struct sockaddr_storage` as `uint32_t` to elevate the alignment of the structure to level of `uint32_t`. This is needed as `struct sockaddr_in` uses an `uint32_t` to store the IPv4 address, previously resulting in `struct sockaddr_in` currently having a greater alignment requirement that `struct sockaddr_storage`.
1e99b07 to
7703b37
Compare
|
Added two commits to enable use of C11 for MIPS and for |
This was referenced Nov 14, 2021
benpicco
approved these changes
Nov 16, 2021
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Align the first member of
struct sockaddrandstruct sockaddr_storageasuint32_tto elevate the alignment of the structure to level ofuint32_t. This is needed asstruct sockaddr_inuses anuint32_tto store the IPv4 address, previously resulting instruct sockaddr_incurrently having a greater alignment requirement thatstruct sockaddr_storage.POSIX sockets should still work, and now do so reliably on platforms that do not support unaligned memory accesses.
Issues/PRs references
Split out of #14955
This contains the same commit to enable C11 for MIPS as #17195 - so if one of the two gets in first the other should be rebased on
master.