-
Notifications
You must be signed in to change notification settings - Fork 2.1k
pkg/littlefs{,2}: fix compilation with -Wcast-align #17151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, my new docker-compose worker seems to have trouble with git-cache not being initialized, which causes pkg checkouts to fail. re-started with new worker disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the "How did this ever worked?" kind of bug
If foo[]
is an array, &foo
is equal to foo
but this is not very readable, though ;)
If the unit tests still pass, it should be fine!
Indeed:
C never stops to surprise me. Let me fix the commit message and PR title then. I'll skip compilation test now, as a change in the commit message shouldn't break any C code. (And if so, that code really had it coming.) |
Hey, Murdock: Skip compile tests ;-P |
Thx! |
Contribution description
As the title says.
Testing procedure
The generated binaries should remain identical to before, but compilation with
-Wcast-align
won't fail.Issues/PRs references
Split out of #14955