docker: pass CONTINUE_ON_EXPECTED_ERRORS into container #16923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
approved these changes
Sep 30, 2021
eb6cdbd to
da6901e
Compare
da6901e to
0a43c23
Compare
0a43c23 to
2219a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Just one more environment variable we need to preserve.
Testing procedure
BOARD=arduino-mega2560 make -C examples/saul all BUILD_IN_DOCKER=1 TOOLCHAIN=llvm CONTINUE_ON_EXPECTED_ERRORS=1Without this patch, "The selected TOOLCHAIN=llvm is not supported." is shown twice (once outside docker, once inside), and the second one still stops compilation.
With this patch, it's still shown twice, but now "EXPECT ERRORS" is printed below both of them, and building is run to the compiler errors that I was hoping to see.
Issues/PRs references
The test case happens to be exactly the invocation with which I'd test #16919, which'd fix the compiler errors.