Skip to content

ci/test-on-iotlab: exclude applications that require riotboot #15772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

ci/test-on-iotlab: exclude applications that require riotboot #15772

merged 1 commit into from
Jan 19, 2021

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jan 14, 2021

Contribution description

This PR excludes from the test-on-iotlab action the applications that require the riotboot feature and which provide a test. These applications cannot work yet on iot-lab (yet) because flashing on iot-lab at a given offset is not supported by the cli-tools.
As a temporary solution until this is fixed in the cli-tools, the examples/suit_update and tests/riotboot are excluded.

Testing procedure

Check that the application are skipped on a manually triggered job, see this run with samr21-xpro on my local fork

Issues/PRs references

None

@aabadie aabadie added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: CI Area: Continuous Integration of RIOT components CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 14, 2021
@aabadie aabadie mentioned this pull request Jan 14, 2021
Merged
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 14, 2021
fjmolinas
fjmolinas approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I agree with the reasoning.

@fjmolinas fjmolinas merged commit 886d179 into RIOT-OS:master Jan 19, 2021
@aabadie aabadie deleted the pr/ci/test-on-iotlab-exclude-riotboot branch January 19, 2021 09:33
@fjmolinas
Copy link
Contributor

Thinking about this a bit late but examples/suit_update does not need to flash at an offset, only riotboot does, so the examples/suit_update issue must be something different no?

@aabadie
Copy link
Contributor Author

aabadie commented Jan 20, 2021

the examples/suit_update issue must be something different no?

Your intuition is correct. On the last run, the problem was that aiocoap-fileserver is not available. Anyway, the test of this application will never work when launched from a github action. It should be covered by #15771. So I'll revert that change.
Maybe I should also exclude tests/periph_timer_short_relative_set because it's expected to fail. Regarding tests/pkg_libfixmath_unittests, it's broken on ARM (at least) but I'm not sure if it should also be excluded. What do you think ?

@aabadie aabadie mentioned this pull request Jan 20, 2021
Merged
@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @fjmolinas @kaspar030