Skip to content

tests/unittests: split out atomic_utils unittests #15438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2020
Merged

tests/unittests: split out atomic_utils unittests #15438

merged 2 commits into from
Nov 13, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 13, 2020

Contribution description

#14331 broke the CI because unittests don't fit anymore on arm7 based boards (msba2 and mcb2388), this PR move the sys atomic_utils from the unittests to their own test application.

Testing procedure

  • A green Murdock
  • Check that tests/sys_atomic_utils_unittests are working:
$ BUILD_IN_DOCKER=1 make -C tests/sys_atomic_utils_unittests all test --no-print-directory 
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/work/riot/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'        -w '/data/riotbuild/riotbase/tests/sys_atomic_utils_unittests/' 'riot/riotbuild:latest' make     all
Building application "tests_sys_atomic_utils_unittests" for "native" with MCU "native".

"make" -C /data/riotbuild/riotbase/boards/native
"make" -C /data/riotbuild/riotbase/boards/native/drivers
"make" -C /data/riotbuild/riotbase/core
"make" -C /data/riotbuild/riotbase/cpu/native
"make" -C /data/riotbuild/riotbase/cpu/native/periph
"make" -C /data/riotbuild/riotbase/cpu/native/stdio_native
"make" -C /data/riotbuild/riotbase/drivers
"make" -C /data/riotbuild/riotbase/drivers/periph_common
"make" -C /data/riotbuild/riotbase/sys
"make" -C /data/riotbuild/riotbase/sys/auto_init
"make" -C /data/riotbuild/riotbase/sys/embunit
"make" -C /data/riotbuild/riotbase/sys/luid
"make" -C /data/riotbuild/riotbase/sys/random
"make" -C /data/riotbuild/riotbase/sys/random/tinymt32
"make" -C /data/riotbuild/riotbase/sys/test_utils/interactive_sync
   text	   data	    bss	    dec	    hex	filename
  52602	    728	  47804	 101134	  18b0e	/data/riotbuild/riotbase/tests/sys_atomic_utils_unittests/bin/native/tests_sys_atomic_utils_unittests.elf
r
/work/riot/RIOT/tests/sys_atomic_utils_unittests/bin/native/tests_sys_atomic_utils_unittests.elf  
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2021.01-devel-832-gfc8b1-pr/tests/sys_atomic_unittest)
.......
OK (7 tests)

Issues/PRs references

Restore the CI that was broken in #14331

@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2020
@aabadie aabadie mentioned this pull request Nov 13, 2020
Merged
@aabadie aabadie force-pushed the pr/tests/sys_atomic_unittest branch from fc8b1f2 to cab2540 Compare November 13, 2020 07:47
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2020
kaspar030
kaspar030 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

maribu
maribu approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kaspar030 kaspar030 added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Nov 13, 2020
@miri64
Copy link
Member

miri64 commented Nov 13, 2020

Unrelated, but regarding size of unittests: I think, now that gnrc_nettype_* are their own pseudo-module, some inclusions of some GNRC modules can be replaced with the corresponding gnrc_nettype_* module (e.g. gnrc_ipv6 to gnrc_nettype_ipv6 in tests-pkt).

@kaspar030 kaspar030 added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2020
@kaspar030
Copy link
Contributor

only unrelated failures:

    tests/driver_ds3231/samr21-xpro:llvm
    tests/driver_ds3231/esp32-wroom-32:gnu
    tests/driver_ds3231/samr21-xpro:gnu
    tests/pkg_libhydrogen/samr21-xpro:llvm

@aabadie aabadie merged commit 4c9ee5d into RIOT-OS:master Nov 13, 2020
@aabadie aabadie deleted the pr/tests/sys_atomic_unittest branch November 13, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@kaspar030 kaspar030 kaspar030 approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @miri64 @kaspar030 @maribu