Skip to content

mtd_mapper: implement pagewise functions #14953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2020
Merged

mtd_mapper: implement pagewise functions #14953

merged 2 commits into from
Nov 17, 2020

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Sep 4, 2020

Contribution description

Implement functions to use the pagewise MTD API.
This way we don't have to fall back to non-pagewise access if the underlying storage implements the pagewise functions.

Testing procedure

tests/mtd_mapper should still work.

Issues/PRs references

@benpicco benpicco requested a review from bergzand September 4, 2020 15:59
@benpicco benpicco added Area: fs Area: File systems Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Sep 4, 2020
@benpicco benpicco requested a review from vincent-d September 4, 2020 15:59
@benpicco
mtd_mapper: implement pagewise functions
43ee53a 
Implement functions to use the pagewise MTD API.
@benpicco benpicco force-pushed the drivers/mtd_mapper-pagewise branch from bb6765c to 43ee53a Compare September 4, 2020 16:00
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 8, 2020
@bergzand
Copy link
Member

bergzand commented Sep 9, 2020

The current test doesn't use the new functions right? Does it make sense to adapt it to also test the pagewise functions?

@benpicco benpicco mentioned this pull request Nov 4, 2020
Merged
5 tasks
@benpicco benpicco requested review from bergzand and removed request for bergzand November 13, 2020 15:07
@benpicco
Copy link
Contributor Author

I updated the test.

@bergzand bergzand self-assigned this Nov 17, 2020
bergzand
bergzand approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@bergzand bergzand merged commit dad5ca3 into RIOT-OS:master Nov 17, 2020
@benpicco benpicco deleted the drivers/mtd_mapper-pagewise branch November 17, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

@vincent-d vincent-d Awaiting requested review from vincent-d

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@bergzand bergzand

Labels
Area: fs Area: File systems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benpicco @bergzand