tests/lwip_sock_tcp: fix -EADDRINUSE test #14668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiled with `LWIP_IPV4=1 LWIP_IPV6=1` this test currently fails in current master. This "regression" was introduced with 035acc2. However, after some debugging I think that commit actually revealed a problem with the test rather than introducing a bug. The test starts the central server, and then checks if opening a listening socket on the same port causes an `-EADDRINUSE` error. The server, on the other hand, starts with `SOCK_FLAGS_REUSE_EP`, so of course the listening operation may succeed. Instead, let's just call `sock_tcp_listen` twice with two distinct queue objects. Way easier and also more correct.
maribu
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
ACK.
The test indeed fails in master and no more with this PR.
The reasoning that indeed the test is testing for incorrect behavior makes sense.
The new test checks if a call after to sock_tcp_listen() (this time without SOCK_FLAGS_REUSE_EP) does not fail after SOCK_FLAGS_REUSE_EP was set, and then a second call to sock_tcp_listen() due to the absence of SOCK_FLAGS_REUSE_EP now fails with -EADDRINUSE. This is exactly the expected behavior according to the API doc.
|
Backport provided in #14670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When compiled with
LWIP_IPV4=1 LWIP_IPV6=1this test currently fails in current master. This "regression" was introduced with 035acc2. However, after some debugging I think that commit actually revealed a problem with the test rather than introducing a bug.The test starts the central server, and then checks if opening a listening socket on the same port causes an
-EADDRINUSEerror. The server, on the other hand, starts withSOCK_FLAGS_REUSE_EP, so of course the listening operation may succeed. Instead, let's just callsock_tcp_listentwice with two distinct queue objects. Way easier and also more correct.Testing procedure
LWIP_IPV4=1 LWIP_IPV6=1 make -C tests/lwip_sock_tcp -j16 flash testshould succeed (but fails in master)
Issues/PRs references
See #14665 (comment)