feat: add type hints to rdflib.util
#2262
Merged
+46
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly so that users can use RDFLib in a safer way, and that we can make safer changes to RDFLib in future. There are also some accomodating type-hint related changes outside of `rdflib.util`. This change does not have a runtime impact.
|
I plan to merge this with no review as all validation passes, and the PR has no runtime changes. |
rdflib.utilrdflib.util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Mainly so that users can use RDFLib in a safer way, and that we can make safer changes to RDFLib in the future.
There are also some accommodating type-hint related changes outside
rdflib.util.This change does not have a runtime impact, as can be seen from https://gist.github.com/aucampia/199693249de4fa71a3b395bcf1805682.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.