Fix for Issue #543 (Namespace unbind required) including trie and other modification #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abhishekvickyvyas would you be willing to update this PR since the in-memory graph has changes? Also, can you please provide some tests? Can't really accept a PR without tests. Thanks. |
Merged
|
Subequently rebased and extended, close when #1985 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #543 ,We added a unbind function which can be called in same way in which we call bind function. We pass the prefix that need to be unbind. In this PR we also take care of Trie and other cases in both rdflib/namespace.py and rdflib/plugins/memory.py .
The example can be given as:-
from rdflib import Graph, Namespace
g = Graph()
g.namespace_manager.bind('abc', Namespace('http://abc.com/xyz/0.1'))
print('--- namespaces before unbinding ----')
for ns in g.namespaces():
print('%s:%s' % (ns))
print
g.namespace_manager.unbind('abc')
print("\n\n")
print('--- namespaces after unbinding ----')
for ns in g.namespaces():
print('%s:%s' % (ns))
print