Cleanup test organization #296
Conversation
Split folders for PyGraph an PyDigraph/PyDAG
Removed test dispatch because it is better to keep it in the top level in order to not repeat unecessary code
Merging updates from qiskit/retworkx
Pull Request Test Coverage Report for Build 704737619
💛 - Coveralls |
Sure. |
There was a problem hiding this comment.
Awesome, thanks for the quick update. This LGTM, I especially appreciate you catching things like test_unique_neighbors_on_graphs which was put in the wrong file (even though the test_neighbors files were already split). Heh, if I had done this I would have completely missed that and just left it in digraph/test_neighbors.
Before I merge this PR though we should give a heads up to @georgios-ts @IvanIsCoding @Chriscrosser3310 and @jlapeyre (which hopefully this comment will be sufficient for) who all have open PRs as this will require them to rebase and move the tests into the new consistent directory structure.
Closes #183.
Creates a cohesive structure for tests by splitting class tests into folders, all
PyGraphclass tests are in thetests/graphfolder and allPyDiGraph/PyDAGtests are in thetests/DiGraphfolder. As before, allretworkx.generatorstests are in thetests/generatorsfolder.There are two exceptions:
test_dispatch.pyis in thetestsfolder because it tests bothPyGraphandPyDigraphand moving this test to separate folders would lead to duplicated code.test_random.pyis in thetestsfolder because it is similar to generators and generates random graphs, however they are not in thegeneratorsmodule, so I was unsure if it is needed to create arandomfolder to put this kind of tests.