Skip to content

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented Feb 17, 2021

This commit adds a new documentation guide for current networkx users on
how to start using retworkx or how to migrate existing networkx code. It
provides a high level explanation of the differences in behavior between
the 2 libraries and how you can you can switch between them.

Fixes #248

TODO:

This commit adds a new documentation guide for current networkx users on
how to start using retworkx or how to migrate existing networkx code. It
provides a high level explanation of the differences in behavior between
the 2 libraries and how you can you can switch between them.

Fixes Qiskit#248
@coveralls
Copy link

coveralls commented Feb 17, 2021

Pull Request Test Coverage Report for Build 603654702

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.412%

Totals Coverage Status
Change from base Build 602746732: 0.0%
Covered Lines: 5697
Relevant Lines: 5909

💛 - Coveralls

@mtreinish mtreinish added this to the 0.8.0 milestone Feb 22, 2021
@mtreinish mtreinish marked this pull request as ready for review February 24, 2021 12:42
@mtreinish mtreinish changed the title [WIP] Add guide on using retworkx for networkx users Add guide on using retworkx for networkx users Feb 24, 2021
@mtreinish
Copy link
Member Author

I think there is still some more we can add here, but this is a decent starting point we can always expand the guide over time. But if people think there are obvious gaps we can add to this before merging.

Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the whole. Few small comments.

Copy link
Contributor

@elfrocampeador elfrocampeador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic copy editing, as is tradition

Comment on lines 29 to 30
While retworkx being written in Rust puts more constraints on how
you interact with graph object. With retworkx you can still attach any Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence feels like a fragment.

@mtreinish mtreinish merged commit fda4b52 into Qiskit:master Feb 26, 2021
@mtreinish mtreinish deleted the add-networkx-users-guide branch February 26, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants