Port transitivity to rustworkx-core #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16283434372Details
💛 - Coveralls |
IvanIsCoding
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the undirected graph and directed graph transitivity functions to rustworkx-core (#1121).
While this is mostly a copy and paste, I changed for loops to iterators and
HashSet::removefor afilterwhen constructing the set.I think the functions
digraph_node_trianglesandgraph_node_trianglesthat count the triangles of a vertex could be part of the public API. Implementing the local clustering is direct using these functions while it doesn't seem part of rustworkx right now.