Add periodic, with_positions to hexagonal_lattice_graph #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
IvanIsCoding
reviewed
Jun 7, 2024
Comment on lines
+81
to
+82
| periodic: bool, | ||
| with_positions: Option<F>, |
There was a problem hiding this comment.
This is a breaking API change on the Rust side. On the Python side, you can use optional arguments but on Rust there is not much we can do.
|
Hi @WingCode -- I noticed that this PR seems to only add |
|
Hi @jpacold , Thank you for asking. Yes, you can go right ahead with issue. I am not sure when I will be able to get back to this issue. |
|
Closing this as obsolete after #1213. Nevertheless, thanks for getting the work started! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #803