Skip to content

Fix clippy findings for Rust 1.74 #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix clippy findings for Rust 1.74 #1030

merged 2 commits into from
Nov 21, 2023

Conversation

IvanIsCoding
Copy link
Collaborator

Some minor improvements suggested by clippy. They are currently blocking all CI actions

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Nov 21, 2023
mtreinish
mtreinish approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this. Although I thought we pinned clippy to our msrv to avoid having to do this every release.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6938826950

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 108 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.7%) to 95.882%
Files with Coverage Reduction New Missed Lines %
src/isomorphism/vf2.rs 1 96.1%
src/matching/mod.rs 1 98.53%
src/token_swapper.rs 1 96.0%
src/json/mod.rs 2 95.0%
src/lib.rs 2 99.45%
src/link_analysis.rs 2 95.69%
src/tree.rs 2 96.0%
src/union.rs 2 95.6%
src/dag_algo/mod.rs 3 98.78%
src/connectivity/mod.rs 4 96.23%
Totals Coverage Status
Change from base Build 6791568926: -0.7%
Covered Lines: 15577
Relevant Lines: 16246
💛 - Coveralls

@mergify mergify bot merged commit 641f0f9 into Qiskit:main Nov 21, 2023
@IvanIsCoding IvanIsCoding deleted the fix-clippy-174 branch January 5, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees

@mtreinish mtreinish

Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanIsCoding @coveralls @mtreinish