Relax constraints in rustworkx-core for hashbrown and indexmap #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the version constraints on the hashbrown and indexmap dependencies in rustworkx-core's dependency list. These 2 dependencies are used for I/O to rustworkx-core and we previously had our versions set to the highest version compatible with the msrv. However, for users of rustworkx-core with newer MSRVs this limited version support caused issues if they wanted to use a newer version of these library (which was compatible with their MSRV) as an input or output to rustworkx-core. For example, as described in Qiskit#911 qiskit-terra was using hashbrown 0.13.x and had errors because the released version of rustworkx-core only was listed as compatible with hashbrown 0.12. This version mismatch meant that the hashbrown objects created in qiskit-terra were not recognized by rustworkx-core because of the version mismatch. This commit attempts to fix this issue by increasing the allowable range of versions to be greater than or equal to our previous fixed version and capped at the last known working version. This should enable users to set a fixed library version that they want even if it's newer and requires a higher MSRV. This commit is for the stable/0.13 branch as the minimum version is lower on the stable branch as the MSRV for the 0.13.0 is much older than what we're using on the main branch now. A separate PR will be pushed up for main to update it there. This was done in reverse in the interest of ensuring we include this in 0.13.1 and the inevitable backport conflict if we started with main first. Fixes Qiskit#911
|
Looks like we have some Clippy errors that are new due to the 1.71 update? Apart from that this LGTM |
IvanIsCoding
approved these changes
Jul 14, 2023
Pull Request Test Coverage Report for Build 5605194288
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the version constraints on the hashbrown and indexmap dependencies in rustworkx-core's dependency list. These 2 dependencies are used for I/O to rustworkx-core and we previously had our versions set to the highest version compatible with the msrv. However, for users of rustworkx-core with newer MSRVs this limited version support caused issues if they wanted to use a newer version of these library (which was compatible with their MSRV) as an input or output to rustworkx-core. For example, as described in #911 qiskit-terra was using hashbrown 0.13.x and had errors because the released version of rustworkx-core only was listed as compatible with hashbrown 0.12. This version mismatch meant that the hashbrown objects created in qiskit-terra were not recognized by rustworkx-core because of the version mismatch. This commit attempts to fix this issue by increasing the allowable range of versions to be greater than or equal to our previous fixed version and capped at the last known working version. This should enable users to set a fixed library version that they want even if it's newer and requires a higher MSRV.
This commit is for the stable/0.13 branch as the minimum version is lower on the stable branch as the MSRV for the 0.13.0 is much older than what we're using on the main branch now. A separate PR will be pushed up for main to update it there. This was done in reverse in the interest of ensuring we include this in 0.13.1 and the inevitable backport conflict if we started with main first.
Fixes #911