Skip to content

fixing up the backend in the example #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2018
Merged

fixing up the backend in the example #396

merged 4 commits into from
Apr 16, 2018

Conversation

jaygambetta
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jaygambetta jaygambetta requested a review from ajavadia April 15, 2018 01:22
diego-plan9
diego-plan9 approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@diego-plan9 diego-plan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good to me - thanks for the follow-up, @jaygambetta !

@diego-plan9 diego-plan9 merged commit 182c2ee into Qiskit:master Apr 16, 2018
ajavadia pushed a commit to ajavadia/qiskit that referenced this pull request Apr 29, 2018
@jaygambetta @ajavadia
fixing up the backend in the example (Qiskit#396)
dbc7d43 
* fixing up the backend in the example

* Adding the wrappers to an inport as in the examples this feel the more natural way to use them.
% Your branch is up to date with 'origin/master'.

* Making cleaner and removing the commeted try

* fixing readme
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
@jaygambetta @diego-plan9
fixing up the backend in the example (Qiskit#396)
7ccb997 
* fixing up the backend in the example

* Adding the wrappers to an inport as in the examples this feel the more natural way to use them.
% Your branch is up to date with 'origin/master'.

* Making cleaner and removing the commeted try

* fixing readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego-plan9 diego-plan9 diego-plan9 approved these changes

@ajavadia ajavadia Awaiting requested review from ajavadia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaygambetta @diego-plan9