-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[WIP] Determine if a given number of qubits can be run locally #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checks local hardware information, and determines if a given number of qubits can be simulated locally.
Currently this is just the code that does the check, but is not integrated. |
@nonhermitian is the intention of this PR to integrate it within QISKit? or just the tool and have an integration later, in another PR. |
Actually, can we explore already existing options for retrieving system information before going with a custom implementation? There seem to be a number of popular ones that might be suited for our purposes (psutil, for example), and would most likely provide a more robust implementation (plus avoiding the burden of having to maintain platform-specific code ourselves). On an unrelated note - pinging @ajavadia to make sure the licensing for the current file in the PR is fine (I wouldn't expect it to be an issue, but just in case)! |
This is new BSD license (clause 3), which is compatible with our Apache 2. |
It is waiting for other things to be finished, and then likely added to the validation part of the local simulators. The code itself is from QuTiP, and has been used for a number of years now without many issues. And indeed, you could drop the qubit count by one, but at least at the moment, I think that is probably unnecessary as the reported total memory is always just below a cutoff. In your case, 31.3 Gb rather than 32. |
@atilag the intention is to make the local simulators check the size they can run rather than just have it hardcore to 30. This way if the user puts it on a bigger computer it can work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this to the backends for the local simulators as well.
The backends are now in aer, so this should be done there. |
i agree |
Checks local hardware information, and determines if a given number of qubits can be simulated locally.
Description
Motivation and Context
Want to prevent users from running simulations that they cannot actually handle.
How Has This Been Tested?
Tested on OSX and Windows. Original code comes from QuTiP.
Screenshots (if appropriate):
Types of changes
Checklist: